Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCTHEME-422: Announce email field as mandatory #2011

Merged
merged 2 commits into from
Mar 18, 2021
Merged

BCTHEME-422: Announce email field as mandatory #2011

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
977a979
BCTHEME-422: Announce email field as mandatory
BC-tymurbiedukhin Mar 17, 2021
3899005
Merge branch 'master' into BCTHEME-422
BC-tymurbiedukhin Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Announce subscribing email field as mandatory. [#2011](https://github.com/bigcommerce/cornerstone/pull/2011)
- Added sold out badge on products within PLP. [#2003](https://github.com/bigcommerce/cornerstone/pull/2003)
- Update focus trap in Modal. [#1998](https://github.com/bigcommerce/cornerstone/pull/1998)
- Added unique identifiers to product cards on product list pages. [#1999](https://github.com/bigcommerce/cornerstone/pull/1999)
Expand Down
1 change: 1 addition & 0 deletions templates/components/common/subscription-form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ <h3 class="footer-info-heading">{{lang 'newsletter.subscribe'}}</h3>
value="{{customer.email}}"
placeholder="{{lang 'newsletter.email_placeholder'}}"
aria-describedby="alertBox-message-text"
aria-required="true"
>
<input class="button button--primary form-prefixPostfix-button--postfix"
type="submit"
Expand Down