Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-429 Unlabelled edit fields on cart page #2016

Merged
merged 2 commits into from
Mar 19, 2021
Merged

fix(storefront): BCTHEME-429 Unlabelled edit fields on cart page #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c129357
fix(storefront): BCTHEME-429 Unlabelled edit fields on cart page
BC-tymurbiedukhin Mar 18, 2021
9e9d210
Merge branch 'master' into BCTHEME-429
BC-tymurbiedukhin Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Added labeling for edit fields on cart page. [#2016](https://github.com/bigcommerce/cornerstone/pull/2016)
- Add placeholder for failed to load carousel images and update scalability. [#2009](https://github.com/bigcommerce/cornerstone/pull/2009)
- Fixed insufficient button label on cart page from action controls. [#2013](https://github.com/bigcommerce/cornerstone/pull/2013)
- "Skip to main content" now is visible when top banned is absent. [#2010](https://github.com/bigcommerce/cornerstone/pull/2010)
Expand Down
1 change: 1 addition & 0 deletions templates/components/cart/content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ <h2 class="cart-item-name">
pattern="[0-9]*"
data-cart-itemid="{{id}}"
data-action="manualQtyChange"
aria-label="{{name}}"
aria-live="polite"{{#unless can_modify}} disabled{{/unless}}>
{{#if can_modify}}
<button class="button button--icon"
Expand Down