Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-496 Translation Gap: Delete from Cart confirmation popup. #2065

Merged
merged 2 commits into from
May 24, 2021
Merged

fix(storefront): BCTHEME-496 Translation Gap: Delete from Cart confirmation popup. #2065

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b148da8
fix(storefront): BCTHEME-496 Translation Gap: Delete from Cart confir…
May 20, 2021
64dcfc1
Merge branch 'master' into BCTHEME-496
BC-tymurbiedukhin May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Translation Gap: Delete from Cart confirmation popup. [#2065](https://github.com/bigcommerce/cornerstone/pull/2065)
- Added settings for payment banners. [#2021](https://github.com/bigcommerce/cornerstone/pull/2021)
- Use https:// for schema markup. [#2039](https://github.com/bigcommerce/cornerstone/pull/2039)
- Update focus tooltip styles contrast to achieve accessibility AA Complaince. [#2047](https://github.com/bigcommerce/cornerstone/pull/2047)
Expand Down
1 change: 1 addition & 0 deletions assets/js/theme/cart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ export default class Cart extends PageManager {
text: string,
icon: 'warning',
showCancelButton: true,
cancelButtonText: this.context.cancelButtonText
}).then((result) => {
if (result.value) {
// remove item from cart
Expand Down
1 change: 1 addition & 0 deletions templates/pages/cart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
cart: true
---
{{inject 'cancelButtonText' (lang 'common.cancel')}}
{{#partial "page"}}
<div class="page">

Expand Down