Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-1037 Remove nanobar #2192

Merged
merged 2 commits into from
Apr 29, 2022
Merged

fix(storefront): BCTHEME-1037 Remove nanobar #2192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a09004
fix(storefront): BCTHEME-1037 Remove nanobar
Apr 1, 2022
030f462
Merge branch 'master' into BCTHEME-1037
bc-yevhenii-buliuk Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Remove nanobar (loading progress bar). [#2192](https://github.com/bigcommerce/cornerstone/issues/2192)
- Fix Workflow examples missing api host. [#2161](https://github.com/bigcommerce/cornerstone/pull/2161)
- Remove sweetAlert. [#2189](https://github.com/bigcommerce/cornerstone/issues/2189)
- Apply security updates (April 2022) [#2200](https://github.com/bigcommerce/cornerstone/issues/2200)
Expand Down
2 changes: 0 additions & 2 deletions assets/js/theme/global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import quickView from './global/quick-view';
import cartPreview from './global/cart-preview';
import privacyCookieNotification from './global/cookieNotification';
import carousel from './common/carousel';
import loadingProgressBar from './global/loading-progress-bar';
import svgInjector from './global/svg-injector';

export default class Global extends PageManager {
Expand All @@ -27,7 +26,6 @@ export default class Global extends PageManager {
menu();
mobileMenuToggle();
privacyCookieNotification();
loadingProgressBar();
svgInjector();
}
}
41 changes: 0 additions & 41 deletions assets/js/theme/global/loading-progress-bar.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions assets/scss/components/_components.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
// Slick carousel
@import "vendor/slick/component";

// Nanobar Ajax loading progress bar
@import "vendor/nanobar/component";


// Foundation components
// -----------------------------------------------------------------------------
Expand Down
5 changes: 0 additions & 5 deletions assets/scss/components/vendor/nanobar/_component.scss
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions assets/scss/components/vendor/nanobar/_nanobar.scss
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"jstree": "^3.3.12",
"lazysizes": "5.2.2",
"lodash": "^4.17.21",
"nanobar": "^0.4.2",
"nod-validate": "^2.0.12",
"object-fit-images": "^3.2.4",
"regenerator-runtime": "^0.13.7",
Expand Down
1 change: 0 additions & 1 deletion webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ module.exports = {
jquery: path.resolve(__dirname, 'node_modules/jquery/dist/jquery.min.js'),
jstree: path.resolve(__dirname, 'node_modules/jstree/dist/jstree.min.js'),
lazysizes: path.resolve(__dirname, 'node_modules/lazysizes/lazysizes.min.js'),
nanobar: path.resolve(__dirname, 'node_modules/nanobar/nanobar.min.js'),
'slick-carousel': path.resolve(__dirname, 'node_modules/slick-carousel/slick/slick.min.js'),
'svg-injector': path.resolve(__dirname, 'node_modules/svg-injector/dist/svg-injector.min.js'),
},
Expand Down