Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-909 Social media icons failing wave scan with Empty Link. #2202

Merged
merged 3 commits into from
Apr 28, 2022
Merged

fix(storefront): BCTHEME-909 Social media icons failing wave scan with Empty Link. #2202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5acc434
fix(storefront): BCTHEME-909 Social media icons failing wave scan wit…
Apr 18, 2022
49e029d
Merge branch 'master' into BCTHEME-909
bc-yevhenii-buliuk Apr 19, 2022
d495223
Merge branch 'master' into BCTHEME-909
bc-yevhenii-buliuk Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Social media icons failing wave scan with "Empty Link". [#2202](https://github.com/bigcommerce/cornerstone/issues/2202)
- Search results containing % symbol result in errored page. [#2205](https://github.com/bigcommerce/cornerstone/issues/2205)
- Remove translations for adminBar component [#2196](https://github.com/bigcommerce/cornerstone/issues/2196)
- Remove adminBar. [#2191](https://github.com/bigcommerce/cornerstone/issues/2191)
Expand Down
12 changes: 10 additions & 2 deletions templates/components/common/social-links.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,16 @@
<ul class="socialLinks socialLinks--alt">
{{#each social_media}}
<li class="socialLinks-item">
<a class="icon icon--{{display_name}}" href="{{url}}" target="_blank" rel="noopener">
<svg><use xlink:href="#icon-{{display_name}}" /></svg>
<a class="icon icon--{{display_name}}"
href="{{url}}"
target="_blank"
rel="noopener"
title="{{{capitalize display_name}}}"
>
<span class="aria-description--hidden">{{{capitalize display_name}}}</span>
<svg>
<use xlink:href="#icon-{{display_name}}"/>
</svg>
</a>
</li>
{{/each}}
Expand Down