Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payment): PAYPAL-1863 deleted non-working code #2301

Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix(payment): PAYPAL-1863 deleted non-working code #2301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
480441d
fix(payment): PAYPAL-1863 delete unnecessary code
bc-nick Dec 30, 2022
36c1244
fix(payment): PAYPAL-1863 fix after review
bc-nick Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed PDP not respecting "quantity box" display settings. [#2291](https://github.com/bigcommerce/cornerstone/pull/2291)
- Added integrarion of storefront-account-payments lib [#2288][https://github.com/bigcommerce/cornerstone/pull/2288]
- Bump Stencil utils to 6.13.0 [#2300][https://github.com/bigcommerce/cornerstone/pull/2300]
- Removed non-working functionality from schema.json [#2301][https://github.com/bigcommerce/cornerstone/pull/2301]

## 6.7.0 (11-03-2022)
- Fixed escaping on created store account confirm message. [#2265]https://github.com/bigcommerce/cornerstone/pull/2265
Expand Down
1 change: 0 additions & 1 deletion config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@
"paymentbuttons-paypal-accelerated-content-color": "white",
"paymentbuttons-paypal-accelerated-content-label": "checkout",
"paymentbuttons-paypal-accelerated-border-color": "black",
"paymentbuttons-paypal-layout": "vertical",
"paymentbuttons-paypal-color": "gold",
"paymentbuttons-paypal-shape": "rect",
"paymentbuttons-paypal-label": "checkout",
Expand Down
17 changes: 0 additions & 17 deletions schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3017,23 +3017,6 @@
}
]
},
{
"type": "select",
"label": "i18n.DisplayStyle",
"id": "paymentbuttons-paypal-layout",
"enable": "payPalProvidersEnabled",
"force_reload": true,
"options": [
{
"value": "horizontal",
"label": "i18n.ShowButtonsHorizontally"
},
{
"value": "vertical",
"label": "i18n.ShowButtonsVertically"
}
]
},
{
"type": "heading",
"content": "i18n.CheckoutPayPalButton",
Expand Down
34 changes: 0 additions & 34 deletions schemaTranslations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4929,40 +4929,6 @@
"no": "PayPal",
"ko": "PayPal 표시"
},
"i18n.ShowButtonsHorizontally": {
"default": "Show buttons horizontally",
"fr": "Afficher les boutons horizontalement",
"it": "Mostra pulsanti in senso orizzontale",
"zh": "水平显示按钮",
"de": "Schaltflächen horizontal anzeigen",
"es": "Mostrar botones en horizontal",
"nl": "Knoppen horizontaal weergeven",
"pt": "Mostrar botões horizontalmente",
"pt-BR": "Mostrar botões horizontalmente",
"sv": "Visa knappar horisontalt",
"es-MX": "Mostrar botones horizontalmente",
"es-419": "Mostrar botones horizontalmente",
"da": "Vis knapper vandret",
"no": "Vis knapper horisontalt",
"ko": "버튼을 가로로 정렬"
},
"i18n.ShowButtonsVertically": {
"default": "Show buttons vertically",
"fr": "Afficher les boutons verticalement",
"it": "Mostra pulsanti in senso verticale",
"zh": "垂直显示按钮",
"de": "Schaltflächen vertikal anzeigen",
"es": "Mostrar botones en vertical",
"nl": "Knoppen verticaal weergeven",
"pt": "Mostrar botões verticalmente",
"pt-BR": "Mostrar botões verticalmente",
"sv": "Visa knappar vertikalt",
"es-MX": "Mostrar botones verticalmente",
"es-419": "Mostrar botones verticalmente",
"da": "Vis knapper lodret",
"no": "Vis knapper vertikalt",
"ko": "버튼을 세로로 정렬"
},
"i18n.CheckoutPayPalButton": {
"default": "PayPal Button on checkout page",
"fr": "Bouton PayPal sur la page de paiement",
Expand Down