fix(storefront): BCTHEME-1481 fix sales badges #2352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-alexsaiannyi
force-pushed
the
BCTHEME-1481
branch
from
e7185bb
to
fe97ee0
Compare
|
Before reviewing/merging PR we need to change a Screenshot with this setting in CP is below. |
|
Closed as this issue will be fixed as part of revert for fix BCTHEME-1171 #2354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes sale badges appearance and and modifies logic for sold-out badges as well that appears after changes in BCTHEME-1171.
Requirements
Tickets / Documentation
Screenshots (if appropriate)
TBD