Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nvm config #2389

Merged
merged 30 commits into from
Aug 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
87df186
docs(storefront): BCTHEME-1013 add readme to lang folder to remove co…
BC-krasnoshapka Jan 31, 2022
790d522
docs(storefront): BCTHEME-1013 add readme to lang folder to remove co…
BC-krasnoshapka Jan 31, 2022
af97975
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Aug 22, 2022
eedddc0
Merge remote-tracking branch 'origin/master'
BC-krasnoshapka Aug 22, 2022
d70ef33
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Sep 2, 2022
fdc8ac0
Merge branch 'master' of https://github.com/BC-krasnoshapka/cornerstone
BC-krasnoshapka Sep 2, 2022
ec559b8
Revert "docs(storefront): BCTHEME-1013 add readme to lang folder to r…
BC-krasnoshapka Sep 2, 2022
965fdca
docs(storefront): BCTHEME-1013 add readme to lang folder to remove co…
BC-krasnoshapka Jan 31, 2022
ef915a0
Revert "docs(storefront): BCTHEME-1013 add readme to lang folder to r…
BC-krasnoshapka Sep 2, 2022
741d472
Merge remote-tracking branch 'origin/master'
BC-krasnoshapka Sep 16, 2022
940b748
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Sep 16, 2022
f9cea23
Merge remote-tracking branch 'origin/master'
BC-krasnoshapka Sep 16, 2022
7ba60d9
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Oct 17, 2022
7ebceeb
Merge remote-tracking branch 'origin/master'
BC-krasnoshapka Oct 17, 2022
d726214
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Nov 11, 2022
7eeb2de
Merge remote-tracking branch 'origin/master'
BC-krasnoshapka Nov 11, 2022
f2732b6
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Feb 9, 2023
7c35da7
Merge remote-tracking branch 'origin/master'
BC-krasnoshapka Feb 9, 2023
a944c0f
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Apr 10, 2023
246bb60
Merge remote-tracking branch 'origin/master'
BC-krasnoshapka Apr 10, 2023
1eca897
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Jul 3, 2023
30abb85
Merge remote-tracking branch 'origin/master'
BC-krasnoshapka Jul 3, 2023
6933c2f
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Jul 20, 2023
ec71d26
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Aug 16, 2023
373b8a0
Merge remote-tracking branch 'origin/master'
BC-krasnoshapka Aug 16, 2023
802f234
chore(storefront): added nvm config and fixed readme typo.
BC-krasnoshapka Aug 16, 2023
cf3c28f
chore(storefront): added nvm config and fixed readme typo.
BC-krasnoshapka Aug 16, 2023
eecc508
Merge remote-tracking branch 'origin/nvm' into nvm
BC-krasnoshapka Aug 16, 2023
fb95d9f
Merge branch 'bigcommerce:master' into master
BC-krasnoshapka Aug 16, 2023
cd6fef3
Merge branch 'master' of https://github.com/BC-krasnoshapka/cornersto…
BC-krasnoshapka Aug 16, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18.15
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Display fees on cart page [#2376](https://github.com/bigcommerce/cornerstone/pull/2376)
- Replace Twitter logo with X logo within social sharing and social link components [#2387](https://github.com/bigcommerce/cornerstone/pull/2387)
- Added nvm config [#2389](https://github.com/bigcommerce/cornerstone/pull/2389)

## 6.12.0 (07-06-2023)
- sync package lock file [#2373](https://github.com/bigcommerce/cornerstone/pull/2373)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ npm install

Note: package-lock.json file was generated by Node version 18 and npm version 9. The app supports Node 18 as well as multiple versions of npm, but we should always use those versions when updating package-lock.json, unless it is decided to upgrade those, and in this case the readme should be updated as well. If using a different version for node OR npm, please delete the package-lock.json file prior to installing node packages and also prior to pushing to github.

If updating or adding a dependency, please double check that you are working on Node version 9 and npm version 9 and run ```npm update <package_name>``` or ```npm install <package_name>``` (avoid running npm install for updating a package). After updating the package, please make sure that the changes in the package-lock.json reflect only the updated/new package prior to pushing the changes to github.
If updating or adding a dependency, please double check that you are working on Node version 18 and npm version 9 and run ```npm update <package_name>``` or ```npm install <package_name>``` (avoid running npm install for updating a package). After updating the package, please make sure that the changes in the package-lock.json reflect only the updated/new package prior to pushing the changes to github.


### Icons
Expand Down
Loading