fix(storefront): BCTHEME-1775 ADA Compliance - Errors are not identified to screen reader users within the Refine By accordions #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-yevhenii-buliuk
force-pushed
the
BCTHEME-1775
branch
from
1e48577
to
8605a58
Compare
…ied to screen reader users within the Refine By accordions
bc-yevhenii-buliuk
force-pushed
the
BCTHEME-1775
branch
from
8605a58
to
a7f594a
Compare
bc-alexsaiannyi
approved these changes
Feb 2, 2024
bc-vlad-dlogush
approved these changes
Feb 2, 2024
bc-azvierieva
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the appropriate aria attributes to announce all possible errors for the price range
Tickets / Documentation
Screen records
before:
1775_before.mov
after:
1775_aria-live_for_errorMessage.mov