fix(storefront): BCTHEME-1770 ADA Compliance - All form fields must be properly labeled #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-vlad-dlogush
approved these changes
Feb 21, 2024
yurytut1993
reviewed
Feb 28, 2024
bc-yevhenii-buliuk
force-pushed
the
BCTHEME-1770
branch
2 times, most recently
from
7d114e3
to
5521741
Compare
…e properly labeled
bc-yevhenii-buliuk
force-pushed
the
BCTHEME-1770
branch
from
5521741
to
82d273a
Compare
yurytut1993
approved these changes
Feb 29, 2024
bc-azvierieva
approved these changes
Mar 1, 2024
|
@bc-yevhenii-buliuk wouldn't it be simpler to add a label for the inputs that is visually hidden? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the appropriate attributes to the input form fields.
Tickets / Documentation
Screen Recording
before:
1770_before.mov
after:
1770_after.mov