Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate u-hiddenVisually in labels #840

Merged
merged 1 commit into from
Sep 16, 2016
Merged

Conversation

bc-annavu
Copy link
Contributor

@bc-annavu bc-annavu commented Sep 2, 2016

The .u- utility classes are being deprecated in version 3.0 of Citadel. In places where u-hiddenVisuallyis being used for labels, replace it with is-srOnly (behavior of this class hides the content to users, but is read out by assistive technology like screen readers).

@bc-miko-ademagic

@bigbot
Copy link

bigbot commented Sep 3, 2016

Autotagging @mickr @mcampa @hegrec

@ghost
Copy link

ghost commented Sep 4, 2016

Nice one 👍

@bc-annavu
Copy link
Contributor Author

@mickr @mcampa @hegrec - anyone have any complaints? i would like to merge this if possible.

@mcampa
Copy link
Contributor

mcampa commented Sep 14, 2016

👍

@bc-annavu
Copy link
Contributor Author

@bc-miko-ademagic @mcampa - can someone merge this in? I don't have access.

@mcampa mcampa merged commit 32575cc into bigcommerce:master Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants