Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STENCIL-2455: Prevents carousel images from being cut off on large sc… #909

Merged
merged 4 commits into from
Feb 8, 2017
Merged

STENCIL-2455: Prevents carousel images from being cut off on large sc… #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75be913
STENCIL-2455: Prevents carousel images from being cut off on large sc…
cristycarpenter Jan 24, 2017
9241c63
STENCIL-2455 add a toggle in the Theme Editor to enable this feature
mcampa Feb 6, 2017
5938c11
STENCIL-2455 Addressing PR comments
mcampa Feb 7, 2017
7a1efdc
STENCIL-2455 adding change notes
mcampa Feb 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Draft
- Added a setting to theme editor schema to show/hide the homepage carousel [#909](https://github.com/bigcommerce/stencil/pull/909)
- Prevent carousel images from being cut off on large screens by adding a new setting to theme editor schema [#909](https://github.com/bigcommerce/stencil/pull/909)

## 1.5.1 (2017-02-07)
- Fix an issue with a horizontal scroll bar showing in theme editor [#915](https://github.com/bigcommerce/stencil/pull/915)
- Hide Gift Certificates when the setting is disabled in the control panel [#914](https://github.com/bigcommerce/stencil/pull/914) & [#916](https://github.com/bigcommerce/stencil/pull/916)
Expand Down
10 changes: 9 additions & 1 deletion assets/scss/components/stencil/heroCarousel/_heroCarousel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
// 3. Visually overrides the top margin for '.body' defined in _body.scss.
// The '.body' top margin creates space between the header and page content.
// However, on the homepage, we want the carousel to be flush with the header.
//
// 4. Allows image to scale on large screens while preventing the top and bottom
// from becoming cut off.
// -----------------------------------------------------------------------------

.heroCarousel {
Expand Down Expand Up @@ -74,7 +77,6 @@
@include carouselOpaqueBackgrounds($slick-dot-bgColor);
}
}

}

.heroCarousel-slide {
Expand All @@ -88,6 +90,12 @@
}
}

.heroCarousel-slide--stretch {
@include breakpoint("large") { // 4
background-size: 100% 100%;
}
}

.heroCarousel-image {
@include breakpoint("medium") { // 1
visibility: hidden;
Expand Down
1 change: 1 addition & 0 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"homepage_featured_products_count": 8,
"homepage_top_products_count": 8,
"homepage_show_carousel": true,
"homepage_stretch_carousel_images": false,
"homepage_new_products_column_count": 4,
"homepage_featured_products_column_count": 4,
"homepage_top_products_column_count": 4,
Expand Down
24 changes: 18 additions & 6 deletions schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,18 @@
{
"name": "Carousel",
"settings": [
{
"type": "checkbox",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this being used ? I do not see any corresponding template change to support it.

Copy link
Contributor

@mcampa mcampa Feb 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here https://github.com/bigcommerce/stencil/search?utf8=%E2%9C%93&q=homepage_show_carousel

"label": "Show Carousel",
"force_reload": true,
"id": "homepage_show_carousel"
},
{
"type": "checkbox",
"label": "Allows image to stretch on large screens",
"force_reload": true,
"id": "homepage_stretch_carousel_images"
},
{
"type": "color",
"label": "Background color",
Expand Down Expand Up @@ -827,11 +839,11 @@
{
"type": "heading",
"content": "Placement"
},
},
{
"type": "checkbox",
"label": "Top Right (Toggle On/Off)",
"force_reload": true,
"force_reload": true,
"id": "social_icon_placement_top"
},
{
Expand Down Expand Up @@ -1237,7 +1249,7 @@
"label": "Product Swatch Image Sizes",
"type": "imageDimension",
"id": "swatch_option_size",
"force_reload": true,
"force_reload": true,
"options": [
{
"value": "22x22",
Expand All @@ -1246,7 +1258,7 @@
{
"value": "custom",
"label": "Specify dimensions"
}
}
]
},
{
Expand Down Expand Up @@ -2190,10 +2202,10 @@
"force_reload": true,
"id": "show_powered_by"
},
{
{
"type": "checkbox",
"label": "Show brands in footer",
"force_reload": true,
"force_reload": true,
"id": "shop_by_brand_show_footer"
},
{
Expand Down
6 changes: 3 additions & 3 deletions templates/components/carousel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"slidesToScroll": 1,
"autoplay": true,
"autoplaySpeed": {{carousel.swap_frequency}}
}'
>
}'>
{{#each carousel.slides}}
<div class="heroCarousel-slide" style="background-image: url({{image}})">
<div class="heroCarousel-slide {{#if ../theme_settings.homepage_stretch_carousel_images}}heroCarousel-slide--stretch{{/if}}"
style="background-image: url({{image}})">
<a href="{{url}}">
<img class="heroCarousel-image" src="{{image}}" alt="{{alt_text}}" title="{{alt_text}}"/>
{{#if heading}}
Expand Down