-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STENCIL-2504 Show account creation only if it is enabled in store settings. #917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
👍 |
Autotagging @mcampa @bc-miko-ademagic @davidchin |
We are now using
|
If account creation is turned off, when the 'Sign in' link is clicked, you are taken to a blank page. Is there a BCApp pr that goes with this one? |
</textarea> | ||
<input type="hidden" name="recaptcha_response_field" value="manual_challenge"> | ||
</noscript> | ||
<div class="panel"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just indenting the markup.
{{/if}} | ||
<div class="form-actions"> | ||
<input type="submit" class="button button--primary" value="{{lang 'forms.create_account.submit_value' }}" /> | ||
<input type="submit" class="button button--primary" value="{{lang 'forms.create_account.submit_value' }}" {{#unless settings.account_creation_enabled}}disabled{{/unless}} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable the submit button if account creation is disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not disable the entire form?
People will think is a bug if you only disable the the submit button
IMO we should not render the entire form if create account is disabled |
@nickdengler to test 1 you will need this bcapp branch https://github.com/bigcommerce/bigcommerce/pull/17364 |
Ok got it now, LGTM 💚 I also added a ticket for the centering (STENCIL-3011) |
This PR fixes 2 things;
@mcampa @mjschock @bigcommerce/stencil-team
@nickdengler can we test this one.