Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STENCIL-3000 adding Changelog file #919

Merged
merged 1 commit into from
Feb 7, 2017
Merged

STENCIL-3000 adding Changelog file #919

merged 1 commit into from
Feb 7, 2017

Conversation

mcampa
Copy link
Contributor

@mcampa mcampa commented Feb 7, 2017

@bigcommerce/stencil-team

@mcampa
Copy link
Contributor Author

mcampa commented Feb 7, 2017 •
edited
Loading

For future PRs:

We are now using CHANGELOG.md. Please add an entry with your change under draft

## Draft
- <here>

## 1.5.1 (2017-02-07)
- Fix an issue with a horizontal scroll bar showing in theme editor [#915](https://github.com/bigcommerce/stencil/pull/915)
- Hide Gift Certificates when the setting is disabled in the control panel [#914](https://github.com/bigcommerce/stencil/pull/914) & [#916](https://github.com/bigcommerce/stencil/pull/916)
- Fix an issue with a close button on the quick search modal on mobile [#918](https://github.com/bigcommerce/stencil/pull/918)
- Adding CHANGELOG.md [#919](https://github.com/bigcommerce/stencil/pull/919)

mattolson
mattolson reviewed Feb 7, 2017
View reviewed changes
CHANGELOG.md Outdated
## 1.5.1

- Fix an issue with a horizontal scroll bar showing in theme editor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of adding a PR# and author name for each entry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, do you have an idea of the format?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the pr link is enough. The link will tell you the author

junedkazi
junedkazi previously requested changes Feb 7, 2017
View reviewed changes
Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did u add a zip file as well to the commit ?

@mcampa
Copy link
Contributor Author

mcampa commented Feb 7, 2017

I deleted the zip file. It was added by mistake on this pr https://github.com/bigcommerce/stencil/pull/915

@junedkazi junedkazi dismissed their stale review February 7, 2017 19:09

I missed that it was a delete change.

@mcampa mcampa force-pushed the CHANGELOG branch 4 times, most recently from d52acf0 to 868d49a Compare February 7, 2017 19:21
@mcampa
Copy link
Contributor Author

mcampa commented Feb 7, 2017 •
edited
Loading

I'm going to make stencil release to change ## draft for the version and date, and post the changes in the github release notes :)

https://github.com/bigcommerce/stencil-cli/pull/275/files

@mattolson
Copy link
Contributor

👍

@mattolson mattolson merged commit 31eedbb into bigcommerce:master Feb 7, 2017
@mcampa mcampa deleted the CHANGELOG branch February 7, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattolson mattolson mattolson left review comments

@junedkazi junedkazi junedkazi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcampa @mattolson @junedkazi