Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STENCIL-2629 - Remove option for "disable" on number of products per page #927

Merged
merged 1 commit into from
Feb 21, 2017
Merged

STENCIL-2629 - Remove option for "disable" on number of products per page #927

merged 1 commit into from
Feb 21, 2017

Conversation

bookernath
Copy link
Contributor

We have this weird option for "disabling" the number of products per page, which makes no sense and is causing confusion.

In the future we may evaluate some kind of best practice for infinite scrolling, but for now we should disable this.

Proof:
image

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense, unless @mcampa opposes.

@junedkazi
Copy link
Contributor

Also we should evaluate the delta between 2 numbers at-least for cornerstone. Right now between 6-8 it is 2, then between 8-9 it is 1 & the next one is 12 where it is 3.

@mcampa
Copy link
Contributor

mcampa commented Feb 20, 2017

hmm, what if a merchant does not want to display one of these sections?
I don't see why this is needed, I actually think is necessary.

Why does not make sense? and why is confusing?
Maybe we don't hide the title, and that's why is confusing?

@mcampa
Copy link
Contributor

mcampa commented Feb 20, 2017

Disregard my message, I thought we were talking about "feature products" and "new products" in the home page

@nickdengler
Copy link
Contributor

The only weird thing is that if a user has this value already set, it will become set as a blank value when they upgrade. This doesn't appear to cause any problems (the storefront shows 20 items when blank, just as it did when it was "disabled"), but calling it out as weird.

💚

@junedkazi junedkazi merged commit c4f8c14 into bigcommerce:master Feb 21, 2017
@bookernath bookernath deleted the STENCIL-2629 branch February 21, 2017 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants