STENCIL-3009 - automatically open review link if hash is included #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @mcampa |
willfaught
reviewed
Feb 20, 2017
assets/js/theme/product.js
Outdated
| @@ -53,6 +53,10 @@ export default class Product extends PageManager { | |||
| return false; | |||
| }); | |||
|
|
|||
| if (window.location.hash.indexOf('write_review') === 1) { | |||
There was a problem hiding this comment.
Just curious: why indexOf instead of substring/===?
|
I think we already have this logic here https://github.com/bigcommerce/stencil/blob/80d48965453f513751f949b498e9c3e6579612c9/assets/js/theme/product.js#L65 We need to fix it there |
|
Nice catch! I'll update there. |
Our product review emails link to the PDP with the hash #write_review included. We need to respond to this hash and automatically pop the review form.
junedkazi
approved these changes
Feb 20, 2017
mcampa
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our product review emails link to the PDP with the hash #write_review
included.
We need to respond to this hash and automatically pop the review form.
Testing/Proof
Visit any product page with #write_review at the end of your URL.