Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STENCIL-2494 - don't over-escape carousel content text #932

Merged
merged 1 commit into from
Feb 20, 2017
Merged

STENCIL-2494 - don't over-escape carousel content text #932

merged 1 commit into from
Feb 20, 2017

Conversation

bookernath
Copy link
Contributor

Using triple braces for text content on Carousel so it doesn't get over-escaped.

Generally we don't consider this a security risk as the content must be entered by the merchant in the control panel.

Proof:
(Before)
image

(After)
image

@bigbot
Copy link

bigbot commented Feb 19, 2017

Autotagging @mcampa @bc-miko-ademagic @davidchin

Copy link
Contributor

@mcampa mcampa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Please add a line to the changelog

@junedkazi junedkazi merged commit e8d7d31 into bigcommerce:master Feb 20, 2017
@bookernath bookernath deleted the STENCIL-2494 branch February 21, 2017 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants