-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STENCIL-3194: Adds theme editor setting for product display mode (grid vs list). #941
Conversation
Fix the newline and this looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add an entry in the changelog file.
schema.json
Outdated
@@ -2105,4 +2124,4 @@ | |||
} | |||
] | |||
} | |||
] | |||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need an extra line I guess.
….Mass comm has been sent. Closing case.Merge branch 'master' of https://github.com/bigcommerce/stencil into STENCIL-3194
schema.json
Outdated
@@ -1065,6 +1065,25 @@ | |||
} | |||
] | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is off on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed now. Thanks!
@@ -26,9 +26,11 @@ | |||
- Remove an unnecessary and confusing option in theme editor [#927](https://github.com/bigcommerce/stencil/pull/927) | |||
- Fix an issue where required product list options would display an invalid "none" choice [#929](https://github.com/bigcommerce/stencil/pull/929) | |||
- Remove unused variable causing js error with search in the nav [#938](https://github.com/bigcommerce/stencil/pull/938) | |||
- Add settings to theme editor schema to customize Optimized Checkout discount banners [#924](https://github.com/bigcommerce/stencil/pull/924) | |||
- Add settings to theme editor schema to customize Optimized Checkout discount banners [#924] (https://github.com/bigcommerce/stencil/pull/924) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is a rebase gone wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move your line to the bottom in the draft section
CHANGELOG.md
Outdated
- Update Optimized Checkout discount banners default values per theme variation [#942](https://github.com/bigcommerce/stencil/pull/942) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space ?
@@ -26,7 +27,7 @@ | |||
- Remove an unnecessary and confusing option in theme editor [#927](https://github.com/bigcommerce/stencil/pull/927) | |||
- Fix an issue where required product list options would display an invalid "none" choice [#929](https://github.com/bigcommerce/stencil/pull/929) | |||
- Remove unused variable causing js error with search in the nav [#938](https://github.com/bigcommerce/stencil/pull/938) | |||
- Add settings to theme editor schema to customize Optimized Checkout discount banners [#924](https://github.com/bigcommerce/stencil/pull/924) | |||
- Add settings to theme editor schema to customize Optimized Checkout discount banners [#924] (https://github.com/bigcommerce/stencil/pull/924) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong. Looks like there is a space.
What?
Adds a "Product display mode" setting to the theme editor so merchants can choose between a grid or list view for their products on category, brand, and search results pages. Product list view functionality already exists in the theme. This change allows merchants to actually use it :)
Tickets / Documentation
https://jira.bigcommerce.com/browse/STENCIL-3194
Screenshots (if appropriate)
Grid Mode (Default):
List Mode: