STENCIL-2934 Add recaptcha v2 support to cornerstone. #951
Conversation
| "hide": "Hide Reviews", | ||
| "new": "Write a Review", | ||
| "show": "Show Reviews", | ||
| "header": "{total, plural, =0{0 Reviews} one {# Review} other {# Reviews}}", | ||
| "rating": "Rating", |
| <div class="form-field"> | ||
| <label class="form-label" for="contact_question">{{lang 'forms.contact_us.question'}} | ||
| <small>{{lang 'common.required' }}</small> | ||
| </label> | ||
| <textarea name="contact_question" id="contact_question" rows="5" cols="50" class="form-input"></textarea> | ||
| </div> | ||
|
|
||
| {{#if forms.contact.recaptcha.enabled}} |
There was a problem hiding this comment.
Moved the field down after the question description field since it is a practice that it should be the last element before the submit.
There was a problem hiding this comment.
do we need to wrap it in the if block?
I think forms.contact.recaptcha.markup will be empty when is disabled.
There was a problem hiding this comment.
I would like to keep the captcha enabled check in place irrespective of what is returned in the markup field.
There was a problem hiding this comment.
That's not how we do this kind of things in Stencil, we removed most of all boolean Blueprint variables because we can check agains the data
junedkazi
changed the title
|
@bigcommerce/stencil-team |
| <div class="form-field"> | ||
| <label class="form-label" for="contact_question">{{lang 'forms.contact_us.question'}} | ||
| <small>{{lang 'common.required' }}</small> | ||
| </label> | ||
| <textarea name="contact_question" id="contact_question" rows="5" cols="50" class="form-input"></textarea> | ||
| </div> | ||
|
|
||
| {{#if forms.contact.recaptcha.enabled}} |
There was a problem hiding this comment.
do we need to wrap it in the if block?
I think forms.contact.recaptcha.markup will be empty when is disabled.
|
💚 LGTM 👍 |
What?
Adding support for google recaptcha v2.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Do Not Merge
It depends on https://github.com/bigcommerce/bigcommerce/pull/17715.
zip:
Cornerstone-recaptcha-v2-1.5.3.zip