Add clearfix to product view details for AMP #965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bookernath
approved these changes
Mar 16, 2017
|
Upon testing, this didn't fix the issue for me. Sent @bc-annavu an example. |
|
Do we still need this PR since we have this fixed in #982 |
|
I don't think so. @bc-annavu ? |
|
Isn't needed anymore. I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There is a bug where the image carousel in AMP will be tiny when there are additional product info added to the product information causes the carousel to resize itself aligned right caused by the floats not being cleared inside the above frame.
@mcampa @junedkazi