Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load amp social share only when we have icons to share. #968

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

junedkazi
Copy link
Contributor

@junedkazi junedkazi commented Mar 16, 2017

What?

Load amp social share only when we have social icons.

Screenshots (if appropriate)

Before

share_before

After

after

@junedkazi junedkazi changed the title Load amp analytics only when we have icons to share. Load amp social share only when we have icons to share. Mar 16, 2017
@bookernath
Copy link
Contributor

👍

@junedkazi
Copy link
Contributor Author

Just a rebase to resolve changelog conflicts.

@junedkazi junedkazi merged commit 2074bc8 into bigcommerce:master Mar 20, 2017
@junedkazi junedkazi deleted the fix-amp-social branch March 20, 2017 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants