Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AMP Carousel on Product Page #982

Merged
merged 2 commits into from
Mar 27, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Load amp social share JS only when we have share icons enabled. [#968](https://github.com/bigcommerce/cornerstone/pull/968)
- Escape html for product summaries in product list view [#980](https://github.com/bigcommerce/cornerstone/pull/980)
- Add `customized_checkout` feature to features list [#974](https://github.com/bigcommerce/stencil/pull/974)
- Fixed AMP Carousel alignment on product view [#982](https://github.com/bigcommerce/cornerstone/pull/982)

## 1.6.2 (2017-03-15)
- Fix a bug that was not updating price and weight when an option is selected [#963](https://github.com/bigcommerce/cornerstone/pull/963)
Expand Down
4 changes: 0 additions & 4 deletions templates/components/amp/css/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,6 @@
}
dl dt {
font-weight: 700;
margin-bottom: .35714rem
}
dl dd {
margin-bottom: 1.5rem
}
abbr,
acronym {
Expand Down
22 changes: 8 additions & 14 deletions templates/components/amp/css/product.html
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
width: 1px
}
.productView-details {
margin-bottom: 2rem
margin-bottom: 1rem
}
.productView-product >:last-child {
margin-bottom: 0
Expand Down Expand Up @@ -152,24 +152,18 @@
.productView-info {
margin-top: .78571rem
}
.productView-info:before,
.productView-info:after {
content: " ";
display: table
}
.productView-info >:last-child {
margin-bottom: 0
}
.productView-info-name,
.productView-info-value {
float: left
display: inline;
margin: 0;
}
.productView-info-name {
clear: both;
margin-bottom: .21429rem;
margin-right: .35714rem
margin-right: 5px;
}
.productView-info-value::after {
content: "\A";
white-space: pre;
}
.productView-info-value {
margin-bottom: .35714rem;
margin-left: 0;
}