Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVDOCS-5551 [update]: MSF, fix incorrect info #2081

Merged
merged 3 commits into from
Oct 19, 2023
Merged

DEVDOCS-5551 [update]: MSF, fix incorrect info #2081

merged 3 commits into from
Oct 19, 2023

Conversation

bc-andreadao
Copy link
Collaborator

@bc-andreadao bc-andreadao commented Oct 19, 2023 •
edited by jira bot
Loading

DEVDOCS-5551

What changed?

  • To remove overrides, you should supply null in a PUT request
  • Endpoint is actually v3/settings/store/profile not v3/settings/profile

@bc-andreadao bc-andreadao marked this pull request as ready for review October 19, 2023 17:22
andrii-lenets
andrii-lenets previously approved these changes Oct 19, 2023
View reviewed changes
@bc-andreadao @andrii-lenets
remove unneeded "&" symbol
67df00f 
Co-authored-by: Andrii Lenets <andrew.lenets@gmail.com>
@bc-andreadao
Copy link
Collaborator Author

Thanks for the catch @andrii-lenets

bc-traciporter
bc-traciporter approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bc-andreadao bc-andreadao merged commit 08eccb6 into main Oct 19, 2023
2 checks passed
@bc-andreadao bc-andreadao deleted the DEVDOCS-5551-store-configuration-doc branch October 19, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bc-traciporter bc-traciporter bc-traciporter approved these changes

@andrii-lenets andrii-lenets andrii-lenets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bc-andreadao @andrii-lenets @bc-traciporter