Skip to content

Commit

Permalink
fix: STRF-10408 Fix unknown level error (#257)
Browse files Browse the repository at this point in the history
  • Loading branch information
jairo-bc authored Mar 17, 2023
1 parent 016412e commit 8173571
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ class HandlebarsRenderer {
*/
_overrideConsoleLog() {
if (this.logger !== console) {
console.log = this.logger.log.bind(this.logger);
console.log = this.logger.info.bind(this.logger);
console.info = this.logger.info.bind(this.logger);
console.error = this.logger.error.bind(this.logger);
console.warn = this.logger.warn.bind(this.logger);
Expand Down
7 changes: 3 additions & 4 deletions spec/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,6 @@ describe('logging', () => {
beforeEach(done => {
sandbox = Sinon.createSandbox();
logger = {
log: Sinon.fake(),
info: Sinon.fake(),
warn: Sinon.fake(),
error: Sinon.fake(),
Expand Down Expand Up @@ -448,15 +447,15 @@ describe('logging', () => {
it('log helper should not be called, when log level = error', done => {
renderer = new HandlebarsRenderer({}, {}, 'v4', logger, 'error');
renderer.renderString('{{log bar}}', context).then(() => {
expect(logger.log.called).to.equal(false);
expect(logger.info.called).to.equal(false);
done();
});
});

it('log helper should not be called, when log level = warning', done => {
renderer = new HandlebarsRenderer({}, {}, 'v4', logger, 'warning');
renderer.renderString('{{log bar}}', context).then(() => {
expect(logger.log.called).to.equal(false);
expect(logger.info.called).to.equal(false);
done();
});
});
Expand Down Expand Up @@ -489,7 +488,7 @@ describe('logging', () => {
it('should override default console.log', done => {
renderer = new HandlebarsRenderer({}, {}, 'v4', logger);
console.log('test');
expect(logger.log.calledWith('test')).to.equal(true);
expect(logger.info.calledWith('test')).to.equal(true);
done();
});

Expand Down

0 comments on commit 8173571

Please sign in to comment.