fix: STRF-9936 Replaced outdated date.js with chrono (#289)

bigcommerce · Aug 25, 2023 · 9675357 · 9675357
1 parent 5b59eb3
commit 9675357
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/helpers/moment.js b/helpers/moment.js
@@ -1,7 +1,7 @@
 'use strict';
 
 const utils = require('./3p/utils');
-const date = require('date.js');
+const chrono = require('chrono-node');
 
 // suppress error messages that are not actionable
 const moment = require('moment');
@@ -40,7 +40,7 @@ const factory = () => {
         // so instead of doing magic we'll just ask the user to tell
         // us if the args should be passed to date.js or moment.
         if (typeof str === 'string' && typeof pattern === 'string') {
-            return moment(date(str)).format(pattern);
+            return moment(chrono.parseDate(str)).format(pattern);
         }
 
         // If handlebars, expose moment methods as hash properties

diff --git a/package.json b/package.json
@@ -35,7 +35,7 @@
   "homepage": "https://github.com/bigcommerce/paper-handlebars",
   "dependencies": {
     "@bigcommerce/handlebars-v4": "4.7.6",
-    "date.js": "^0.3.3",
+    "chrono-node": "^2.6.5",
     "handlebars": "3.0.8",
     "he": "^1.2.0",
     "moment": "^2.29.4",

diff --git a/spec/helpers/moment.js b/spec/helpers/moment.js
@@ -14,6 +14,26 @@ describe('moment helper', function () {
             {
                 input: `{{moment "1 year ago" "YYYY"}}`,
                 output: `${now.getFullYear() - 1}`,
+            },
+            {
+                input: `{{moment "2 days ago" "YYYY"}}`,
+                output: `${now.getFullYear()}`,
+            },
+            {
+                input: `{{moment '2022-06-29' 'DD/MM/YYYY'}}`,
+                output: '29/06/2022',
+            },
+            {
+                input: `{{moment '2022-06-30' 'DD/MM/YYYY'}}`,
+                output: '30/06/2022',
+            },
+            {
+                input: `{{moment '2022-07-29' 'DD/MM/YYYY'}}`,
+                output: '29/07/2022',
+            },
+            {
+                input: `{{moment '2022-07-30' 'DD/MM/YYYY'}}`,
+                output: '30/07/2022',
             }
         ], done);
     });