Support floats for assignVar/getVar #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-bc
previously approved these changes
Nov 16, 2021
mattolson
reviewed
Nov 16, 2021
helpers/assignVar.js
Outdated
| if (!utils.isString(value) && !Number.isInteger(value)) { | ||
| throw new Error("assignVar helper value must be a string or a number (integer)"); | ||
| // Validate that value is a string or Number (int/float) | ||
| if (!utils.isString(value) && isNaN(value)) { |
There was a problem hiding this comment.
I would use Number.isFinite(value) here for a more robust and less surprising implementation: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite
bookernath
force-pushed
the
assignVar-floats
branch
from
e7bd9b1 to
861b704
Compare
bookernath
force-pushed
the
assignVar-floats
branch
from
861b704 to
4982311
Compare
|
I think this is good to merge. |
jmwiese
approved these changes
Nov 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Add support for floats in assignVar/getVar helpers by customer request.
How was it tested?
Test added.
cc @bigcommerce/storefront-team