STRF-9658 Add log level variable to control log helper #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwiese
reviewed
Feb 17, 2022
| */ | ||
| constructor(siteSettings, themeSettings, hbVersion, logger = console) { | ||
| constructor(siteSettings, themeSettings, hbVersion, logger = console, logLevel = 'info') { |
There was a problem hiding this comment.
Do we want to make this configurable via environment variable?
There was a problem hiding this comment.
yes. it will be in the renderer. It's basically the way to pass down it through libraries
jmwiese
previously approved these changes
Feb 17, 2022
mattolson
reviewed
Feb 17, 2022
| * @param {String} level | ||
| */ | ||
| setLoggerLevel(level) { | ||
| this.handlebars.logger.level = level; |
There was a problem hiding this comment.
Not sure that this will work for console. Can you write a test for that?
There was a problem hiding this comment.
sure, added!
This behaviour is possible due to this if condition:
https://github.com/bigcommerce/paper-handlebars/blob/master/index.js#L332
mattolson
approved these changes
Feb 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
To get ability to log errors from paper and handlebars and fix the issue that caused https://jira.bigcommerce.com/browse/STRF-7500
How was it tested?
npm test, e2e
cc @bigcommerce/storefront-team