Bump lodash version #161
Merged
Bump lodash version #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-max
previously approved these changes
Feb 21, 2022
bc-jz
reviewed
Feb 23, 2022
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ## 4.5.3 | |||
| - Bump lodash version to 4.17.21 ([#x](https://github.com/bigcommerce/paper-handlebars/pull/x)) | |||
There was a problem hiding this comment.
Should this have a pull request number instead of x in the URL?
bc-jz
reviewed
Feb 23, 2022
| @@ -30,7 +30,7 @@ | |||
| "handlebars-helpers": "0.8.4", | |||
| "handlebars-utils": "^1.0.6", | |||
| "he": "^1.2.0", | |||
| "lodash": "^4.17.13", | |||
| "lodash": "^4.17.21", | |||
There was a problem hiding this comment.
what is lodash used for in handlebars?
There was a problem hiding this comment.
It's an utility library, mostly used for iterating some different structures, objects.
I believe it's possisble to get rid of it
There was a problem hiding this comment.
Is that something you would advise doing if possible? Maybe a follow up if not simple to strip?
There was a problem hiding this comment.
I created a follow up ticket: https://jira.bigcommerce.com/browse/STRF-9673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Snyk suggestions
https://app.snyk.io/org/bigcommerce/project/e947f4e9-85ef-4858-a86a-82bcdd6b2452/pr-check/350f32d1-efcd-42b0-8a4a-bea671eee6be
How was it tested?
npm testcc @bigcommerce/storefront-team