bugfix & setup to replace 3p helpers incrementally #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-evan-johnson
force-pushed
the
STRF-9873-patch-2
branch
from
d8ae124 to
b3eac73
Compare
jairo-bc
reviewed
Jul 8, 2022
spec/helpers/option.js
Outdated
| }, | ||
| ], done); | ||
| }); | ||
| // it('accepts SafeString paths', (done) => { |
There was a problem hiding this comment.
Shouldn't it be supported now?
There was a problem hiding this comment.
The old option helper (and also get) only works with SafeString for top-level properties, not nested properties, so this test will fail on the old version.
| @@ -11,7 +11,7 @@ const helpersList = [ | |||
| 'dynamicComponent', | |||
| 'encodeHtmlEntities', | |||
| 'for', | |||
| 'get', | |||
| // 'get', | |||
There was a problem hiding this comment.
Lets maybe enable 1 helper here? Maybe get
There was a problem hiding this comment.
Let's start with moment and option.
bc-evan-johnson
force-pushed
the
STRF-9873-patch-2
branch
from
b3eac73 to
0a79e62
Compare
jairo-bc
approved these changes
Jul 11, 2022
This was referenced Jul 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
The previous iteration of these helper replacements broke backwards compatibility in a couple of previously-unknown edge cases.
Note: The helper replacements will be enabled in future PRs.
How was it tested?
Additional unit test cases have been added. Both the new and old versions pass the new test cases.
cc @bigcommerce/storefront-team