Add original stack trace to render error #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
We're seeing a lot of errors about 'hash' undefined in renderer that spike occasionally and result in 500s https://kibana.bigcommerce.net/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-2d,to:now))&_a=(columns:!(template_path,template_engine,message,store_id),filters:!(),index:production_containers_storefront-renderer,interval:auto,query:(language:kuery,query:'%22Cannot%20read%20property%20!'hash!'%20of%20null%22'),sort:!(!('@timestamp',desc)))
We're attempting to diagnose what exactly is failing within handlebars when we have a RenderError, so add the original stack trace to the error message
How was it tested?
cc @bigcommerce/storefront-team