Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: STRF-10122 Fix inArray helper, when array is undefined #201

Merged
merged 1 commit into from
Oct 6, 2022
Merged

fix: STRF-10122 Fix inArray helper, when array is undefined #201

merged 1 commit into from
Oct 6, 2022

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Oct 6, 2022

What? Why?

Original error:
Cannot read property 'length' of undefined

Happened in inArray helper, when array is undefined.

How was it tested?

npm test


cc @bigcommerce/storefront-team

Copy link
Contributor

@jordanarldt jordanarldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jairo-bc jairo-bc merged commit 0608d0b into bigcommerce:master Oct 6, 2022
@jairo-bc jairo-bc mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants