Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-10124 Clean up handlebars dependencies #209

Merged
merged 1 commit into from
Oct 17, 2022
Merged

STRF-10124 Clean up handlebars dependencies #209

merged 1 commit into from
Oct 17, 2022

Conversation

jairo-bc
Copy link
Contributor

What? Why?

Rework of #199

How was it tested?

npm test, cdvm


cc @bigcommerce/storefront-team

Copy link
Contributor

@rafa-avila-bc rafa-avila-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are a couple of files that could benefit from the p3/utils. Check comments.

@@ -22,7 +21,7 @@ module.exports = function markdown(config) {
return md.render(context);
}

if (utils.isObject(context) && typeof context.fn === 'function') {
if (typeof context === 'object' && typeof context.fn === 'function') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use the p3/utils?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunatelly it won't work and causes circular dependency

@jairo-bc jairo-bc merged commit 3a0c629 into bigcommerce:master Oct 17, 2022
@jairo-bc jairo-bc mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants