Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi concat #236

Merged
merged 15 commits into from
Mar 14, 2023
Merged

Conversation

juliachen-arcticleaf
Copy link
Contributor

What? Why?

Adding multiConcat handlebar helper for concatenate function which accepts more than 2 elements

How was it tested?

create test cases that accept string, boolean, number, empty string


cc @bigcommerce/storefront-team

Copy link
Contributor

@bc-evan-johnson bc-evan-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jairo-bc jairo-bc changed the title Feature/multi concat feat: multi concat Mar 14, 2023
@jairo-bc
Copy link
Contributor

cc @bigcommerce/dev-docs

@jairo-bc jairo-bc merged commit bb829aa into bigcommerce:master Mar 14, 2023
@juliachen-arcticleaf
Copy link
Contributor Author

LGTM 👍

Thanks, Jairo! What would be the next steps?

@jairo-bc
Copy link
Contributor

@juliachen-arcticleaf We will take this version to the next release, that will happen during this week.

@juliachen-arcticleaf
Copy link
Contributor Author

@juliachen-arcticleaf We will take this version to the next release, that will happen during this week.
That's nice! Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants