Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: STRF-11900 Drop node 18, add node 20, 22 #324

Merged
merged 1 commit into from
Aug 19, 2024
Merged

feat: STRF-11900 Drop node 18, add node 20, 22 #324

merged 1 commit into from
Aug 19, 2024

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Aug 19, 2024 •
edited
Loading

What? Why?

  • Breaking changes: Drop node support 16, 18
  • Add node 20, 22
  • Updated several packages related to CI
  • Removed blackbird CI step

How was it tested?

npm test

cc @bigcommerce/storefront-team

@jairo-bc jairo-bc force-pushed the STRF-11900 branch 4 times, most recently from 3bf1e32 to ed49de3 Compare August 19, 2024 12:12
@jairo-bc jairo-bc requested a review from a team August 19, 2024 14:00
huntario
huntario reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@huntario huntario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.nvmrc Outdated Show resolved Hide resolved
@jairo-bc jairo-bc force-pushed the STRF-11900 branch 2 times, most recently from 05f68c0 to d5a3cf4 Compare August 19, 2024 15:52
@jairo-bc jairo-bc requested a review from huntario August 19, 2024 15:59
@jordanarldt jordanarldt self-assigned this Aug 19, 2024
jordanarldt
jordanarldt approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@jordanarldt jordanarldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran npm install and npm test on both node 20 and node 22, works as expected. Approved! 💚

@jairo-bc jairo-bc merged commit 26341d2 into master Aug 19, 2024
3 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanarldt jordanarldt jordanarldt approved these changes

@huntario huntario Awaiting requested review from huntario

Assignees

@bc-jz bc-jz

@jordanarldt jordanarldt

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jairo-bc @huntario @jordanarldt @bc-jz