Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-7011 Release 4.1.0 #64

Merged

Conversation

bc-williamkwon
Copy link
Contributor

@bc-williamkwon bc-williamkwon commented Jul 10, 2019

What? Why?

Release 4.1.0

  • Upgrade Lodash to 4.17.13
  • Reduce arguments usage where possible
  • Refactor helper functions to use Handlebars utils type checks instead of Lodash type checks
  • Add getImageSrcset helper
  • Refactor getImage helper to return image URL as SafeString instead of string

cc @bigcommerce/storefront-team

@bookernath
Copy link
Contributor

@bc-williamkwon I think this should be 4.1.0 as we've added new features (getImageSrcset)

@bc-williamkwon
Copy link
Contributor Author

changed.

@bc-williamkwon
Copy link
Contributor Author

Actually, need to change commit message too.

@ncheikh
Copy link

ncheikh commented Jul 10, 2019

What is our release process? (Docs appreciated if they exist)

@bc-williamkwon
Copy link
Contributor Author

The first time, I did it I just made version bumps and updated package-locks to everything for the storefront renderer side. There were npm publishes that were done but that was not by me. Not sure where the docs are and need to figure that out.

@bc-williamkwon bc-williamkwon merged commit 4c73e84 into bigcommerce:master Jul 10, 2019
@bc-williamkwon bc-williamkwon changed the title STRF-7011 Release 4.0.10 STRF-7011 Release 4.1.0 Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants