Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STRF-4420: Remove direct access to siteSettings and themeSettings #131

Merged
merged 1 commit into from
Jan 31, 2018
Merged

STRF-4420: Remove direct access to siteSettings and themeSettings #131

merged 1 commit into from
Jan 31, 2018

Conversation

mattolson
Copy link
Contributor

@mattolson mattolson commented Jan 31, 2018 •
edited
Loading

  • Bump paper-handlebars to 3.0
  • We no longer store siteSettings and themeSettings directly on the paper object.
  • Create accessors for these objects and delegate them to HandlebarsRenderer.
  • Change assembler attribute to _assembler to signal that this should not be accessed directly.

@mattolson
STRF-4420: Remove direct access to siteSettings and themeSettings
d55fb2f 
* We no longer store these directly on the paper object.
* Create accessors for these objects and delegate them to renderer.
@mattolson mattolson merged commit b8d2cb2 into bigcommerce:master Jan 31, 2018
@mattolson mattolson deleted the STRF-4420 branch January 31, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedkazi junedkazi junedkazi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattolson @junedkazi