STRF-7393 fix renderTheme function to work with Stencil CLI #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-williamkwon
force-pushed
the
fixRenderThemeFunction
branch
3 times, most recently
from
50d977a to
5e6768e
Compare
ncheikh
reviewed
Oct 3, 2019
| const themeComponents = ['pages/product', 'pages/partial', 'pages/greet', 'pages/pre']; | ||
|
|
||
| it('should render theme', function(done) { | ||
| const paper = new Paper(null, null, assembler); |
There was a problem hiding this comment.
Does this test cover the case we were seeing with partials not be rendered?
There was a problem hiding this comment.
Pages/partial is in pages/product and its content is part of the value for pages/product in the object. The issue with renderTheme function was that the for in loop was using numeric indices and thus not grabbing the actual values of elements in templatePath.
mattolson
reviewed
Oct 3, 2019
bc-williamkwon
force-pushed
the
fixRenderThemeFunction
branch
from
5e6768e to
3e6f8c3
Compare
bc-williamkwon
force-pushed
the
fixRenderThemeFunction
branch
from
3e6f8c3 to
57f3a38
Compare
mattolson
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, renderTheme function would not work properly when an ajax call resulted in having a templatePath with multiple templates. This fix should allow it to work now.
https://jira.bigcommerce.com/browse/STRF-7393