BCTHEME-276: Add option to escape values in inject helper #233
+33
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to bigcommerce/paper-handlebars#138
What
Adding an optional param to the inject helper so developers can choose to escape injected values.
Why
To prevent XSS when user-writeable fields are injected with the inject helper. By making this an optional argument, developers can opt in to escaping values, and existing theme customizations should not be impacted.
Testing
Added tests and ran all unit tests
Started Stapler locally with this version of Paper and compared injected values in console log with custom Cornerstone.