STRF-9124 Create an endpoint for precaching lang helper function #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwiese
reviewed
May 17, 2021
index.js
Outdated
| @@ -286,9 +286,18 @@ class Paper { | |||
| * | |||
| * @param {Object} templats | |||
| */ | |||
| addTemplates(templates) { | |||
| addTemplates(templates) { | |||
There was a problem hiding this comment.
🍹 extra space at beginning of line
jmwiese
reviewed
May 17, 2021
| if (err.name === 'SyntaxError') { | ||
| this.logger.error(`Syntax Error during Formatter function precompilation: ${err.message} for key "${key}"`, err.expected); | ||
|
|
||
| return () => ''; |
There was a problem hiding this comment.
Is this not a situation where we want to also throw an error? Why do we just want to return empty string here?
There was a problem hiding this comment.
I'm not sure why it was there, I've just used the same logic as it was at current helper implementation to have compatibility
jmwiese
reviewed
May 17, 2021
lib/translator/index.js
Outdated
| @@ -104,14 +153,22 @@ Translator.prototype.getLocale = function () { | |||
| * @param {string} [keyFilter] | |||
| * @returns {Object} Language object | |||
| */ | |||
| Translator.prototype.getLanguage = function (keyFilter) { | |||
| Translator.prototype.getLanguage = function (keyFilter) { | |||
jmwiese
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.