Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STRF-9227 Address Polyglot exceptions #243

Merged
merged 1 commit into from
Jun 17, 2021
Merged

STRF-9227 Address Polyglot exceptions #243

merged 1 commit into from
Jun 17, 2021

Conversation

jairo-bc
Copy link
Contributor

  1. In case if translation key is not string, we try to set it to string.
  2. Do not break render operation if some translation key is not possible to precompile because of wrongly formatted (or other reason)

cc @bigcommerce/storefront-team

@junedkazi junedkazi merged commit e0e0848 into bigcommerce:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwiese jmwiese jmwiese approved these changes

@junedkazi junedkazi junedkazi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jairo-bc @junedkazi @jmwiese