Skip to content

Commit

Permalink
Adding Support for Node 10 (#525)
Browse files Browse the repository at this point in the history
* chore: updating stencil-styles version and engines for node 10-12

* chore: reduced to node 11 in node engines

* chore: updating travis to run all supported node versions to ensure no regressions

* chore: removing support for node 11 as it doesn't pass tests

* chore: removing non-major node versions from appveyor

* chore: merged upstream master

* chore: packages updated for node 12

* chore: updated cicd to run node 11 and 12

* chore: updated cicd/travis for node 11 and 12

* Revert "chore: updated cicd to run node 11 and 12"

This reverts commit 210b05f.

* Revert "chore: packages updated for node 12"

This reverts commit 5c6d11c.

* chore: reverting cicd from node 12 changes

* chore: updated readme
  • Loading branch information
Nabil Cheikh authored Oct 14, 2019
1 parent 4ef7b34 commit 3013fb4
Show file tree
Hide file tree
Showing 5 changed files with 67 additions and 47 deletions.
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ addons:
- github.com
node_js:
- 8
- 10

cache:
directories:
- node_modules
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
The BigCommerce server emulator for local theme development.

## Install
_Note: Stencil requires the Node.js runtime environment, version 8.x. We do not yet have support for Node 10 or greater._
_Note: Stencil requires the Node.js runtime environment, version 8.x or 10.x We do not yet have support for Node 12 or greater._

Run `npm install -g @bigcommerce/stencil-cli`.

Expand Down
2 changes: 2 additions & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
environment:
matrix:
- nodejs_version: "8"
- nodejs_version: "10"

platform:
- x86
- x64
Expand Down
102 changes: 59 additions & 43 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "CLI tool to run BigCommerce Stores locally for theme development.",
"main": "index.js",
"engines": {
"node": ">= 8.0.0 <9.0.0"
"node": ">= 8.0.0 <11.0.0"
},
"scripts": {
"lint": "eslint .",
Expand Down Expand Up @@ -38,7 +38,7 @@
"homepage": "https://github.com/bigcommerce/stencil-cli",
"dependencies": {
"@bigcommerce/stencil-paper": "^3.0.0-rc.24",
"@bigcommerce/stencil-styles": "1.1.0",
"@bigcommerce/stencil-styles": "1.2.0-rc1",
"accept-language-parser": "^1.0.2",
"archiver": "^0.14.4",
"async": "^2.4.0",
Expand Down Expand Up @@ -116,7 +116,7 @@
"gulp-git-streamed": "2.4.0",
"gulp-if": "2.0.0",
"gulp-prompt": "0.1.2",
"gulp-sass": "4.0.1",
"gulp-sass": "4.0.2",
"gulp-sass-lint": "1.1.1",
"gulp-util": "3.0.7",
"husky": "^1.2.0",
Expand Down

0 comments on commit 3013fb4

Please sign in to comment.