Adding Support for Node 10 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bookernath
approved these changes
Oct 10, 2019
added 9 commits
October 10, 2019 14:18
No need to wait. Node Sass already supports node 12. |
junedkazi
reviewed
Oct 14, 2019
| @@ -7,6 +7,8 @@ addons: | |||
| - github.com | |||
| node_js: | |||
| - 8 | |||
| - 10 | |||
There was a problem hiding this comment.
Should we add 9 as well ?
There was a problem hiding this comment.
I don't think so, odd versions are only supported for a short time and I don't think we need to support node versions that aren't supported for cli. In the future I can see doing the leading version like 13 for early adopters and it helps us make sure we are in a good position for the next even/lts release.
Thoughts?
junedkazi
reviewed
Oct 14, 2019
| @@ -4,7 +4,7 @@ | |||
| "description": "CLI tool to run BigCommerce Stores locally for theme development.", | |||
| "main": "index.js", | |||
| "engines": { | |||
| "node": ">= 8.0.0 <9.0.0" | |||
| "node": ">= 8.0.0 <11.0.0" | |||
There was a problem hiding this comment.
Also can we also update the readme to reflect node version support.
ncheikh
commented
Oct 14, 2019
| @@ -6,7 +6,7 @@ | |||
| The BigCommerce server emulator for local theme development. | |||
|
|
|||
| ## Install | |||
| _Note: Stencil requires the Node.js runtime environment, version 8.x. We do not yet have support for Node 10 or greater._ | |||
| _Note: Stencil requires the Node.js runtime environment, version 8.x or 10.x We do not yet have support for Node 12 or greater._ | |||
|
|
|||
There was a problem hiding this comment.
@junedkazi @bookernath Let me know if we want different messaging here.
junedkazi
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updating stencil styles dependency which allows node 10 support.
Tested