Merge pull request #573 from junedkazi/drop-theme-editor

feat: deprecate theme editor

.eslintignore

@@ -1,2 +0,0 @@
-server/plugins/stencil-editor/public/**/*.js
-server/plugins/stencil-editor/js/*.js

README.md

@@ -39,7 +39,6 @@ Run `stencil start` to run a local server so you can start developing your theme
 Run with `-o` or `--open` to automatically open up a browser.
 
 - While stencil is running, you can type "rs" and then hit enter to auto-reload all browsers. This is similar to Nodemon's rs option.
-- Run with `-e` to load a local Theme Editor.
 
 Run `stencil bundle` to validate your code and create a zip bundle file that can be uploaded to BigCommerce.
 

bin/stencil-start

@@ -37,7 +37,6 @@ Program
     .option('-v, --variation [name]', 'Set which theme variation to use while developing')
     .option('-t, --test', 'Enable QA mode which will bundle all javascript for speed to test locally')
     .option('--tunnel [name]', 'Create a tunnel URL which points to your local server that anyone can use.')
-    .option('-e, --theme-editor', 'Run Theme Editor server')
     .option('-n, --no-cache', 'Turns off caching for API resource data per storefront page. The cache lasts for 5 minutes before automatically refreshing.')
     .parse(process.argv);
 
@@ -152,8 +151,6 @@ function startServer() {
     var params = {
         dotStencilFile: dotStencilFile,
         variationIndex: themeConfig.variationIndex || 0,
-        stencilEditorEnabled: Program.themeEditor,
-        stencilEditorPort: Program.themeEditorPort || 8181,
         useCache: Program.cache,
         themePath: themePath,
     };

gulpfile.js

@@ -19,12 +19,6 @@ let remote;
 let responses;
 let targetVersion;
 
-function installPrivateDependencies() {
-    return gulp.src('package.json')
-        .pipe(exec('npm run install-private-dependencies'), logError)
-        .on('error', logError);
-}
-
 function bumpTask() {
     const questions = [{
         type: 'list',
@@ -94,20 +88,8 @@ function bumpTask() {
         .on('error', logError);
 }
 
-function deployWebpack() {
-    return gulp.src('package.json')
-        .pipe(exec('npm run deploy'), logError)
-        .on('error', logError);
-}
-
-function uninstallPrivateDependencies() {
-    return gulp.src('package.json')
-        .pipe(exec('npm run uninstall-private-dependencies'), logError)
-        .on('error', logError);
-}
-
 function pushTask() {
-    return gulp.src(['package.json', 'package-lock.json', 'CHANGELOG.md', 'server/plugins/stencil-editor/public/dist/app.js', 'server/plugins/stencil-editor/public/dist/ng-stencil-editor/css/ng-stencil-editor.min.css', 'server/plugins/stencil-editor/public/dist/stencil-preview-sdk.js'])
+    return gulp.src(['package.json', 'package-lock.json', 'CHANGELOG.md'])
         // Add files
         .pipe(git.add())
         // Commit the changed version number
@@ -127,10 +109,7 @@ function logError(err) {
     }
 }
 
-gulp.task('install-private-dependencies', installPrivateDependencies);
 gulp.task('bump', bumpTask);
-gulp.task('deploy-webpack', deployWebpack);
 gulp.task('changelog', done => changelog.changelogTask({}, done));
-gulp.task('uninstall-private-dependencies', uninstallPrivateDependencies);
 gulp.task('push', pushTask);
-gulp.task('release', gulp.series('install-private-dependencies', 'bump', 'deploy-webpack', 'changelog', 'uninstall-private-dependencies', 'push'));
+gulp.task('release', gulp.series('bump', 'changelog', 'push'));

lib/stencil-bundle.js

@@ -1,4 +1,5 @@
 'use strict';
+
 const MEGABYTE = 1048576;
 const MAX_SIZE_BUNDLE = MEGABYTE * 50;
 const PATHS_TO_ZIP = [
@@ -350,7 +351,7 @@ function bundleTaskRunner(callback) {
 
 /**
  * Archive theme files
- * @param {Archive} archive
+ * @param {Archiver} archive
  * @param {String} themePath
  * @param {Object} configuration
  */
@@ -371,7 +372,7 @@ function bundleThemeFiles(archive, themePath, configuration) {
 
 /**
  * Archive all generated files (ex. parsed files)
- * @param {Archive} archive
+ * @param {Archiver} archive
  * @param {Object} taskResults
  * @returns {Array}
  */