fix(storefront): bctheme-1284 Fix error on using scoped nested external templates #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-alexsaiannyi
force-pushed
the
bctheme-1284
branch
from
89f88b1 to
f6c97ec
Compare
bc-alexsaiannyi
force-pushed
the
bctheme-1284
branch
from
f6c97ec to
fce911b
Compare
BC-krasnoshapka
approved these changes
Oct 18, 2022
jairo-bc
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently we experience an error on attempt to use nested templates from external scoped modules due to special symbols . For instance, if we use some external template in our stencil theme where we re-use some other nested template from external and scoped module (like an UI library with styles and templates) we receive parsing error due to special symbol
@. We've wrapped all such nested templates into quotes to prevent this behaviour.Tickets / Documentation
Screenshots (if appropriate)
categories-testtemplate uses a nested template inside:cc @bigcommerce/storefront-team, @bigcommerce/themes-team