fix(storefront): strf-10193 Bad request for custom front matter: #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-max
force-pushed
the
STRF-10193-Bad-request-for-custom-front-matter
branch
2 times, most recently
from
5175a25 to
72cc3de
Compare
bc-max
force-pushed
the
STRF-10193-Bad-request-for-custom-front-matter
branch
from
34d8d18 to
afc2104
Compare
rafa-avila-bc
approved these changes
Nov 2, 2022
jairo-bc
reviewed
Nov 2, 2022
jairo-bc
reviewed
Nov 2, 2022
jairo-bc
reviewed
Nov 2, 2022
| @@ -369,10 +362,10 @@ internals.getTemplatePath = (requestPath, data) => { | |||
|
|
|||
| if (templatePath) { | |||
| templatePath = path.join('pages/custom', pageType, templatePath.replace(/\.html$/, '')); | |||
| // eslint-disable-next-line no-param-reassign | |||
| data.template_file = templatePath; | |||
There was a problem hiding this comment.
Or maybe do you to return here the value and leave the name as it is and we exit iterating over the layouts
There was a problem hiding this comment.
It's better to rename as we need updated bcapp data earlier than just template path.
- template is get locally; - test fix;
bc-max
force-pushed
the
STRF-10193-Bad-request-for-custom-front-matter
branch
from
d234e5d to
9356617
Compare
|
🎉 This PR is included in version 5.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We don't need to send any data to
bcappsince stencil can take all data from local theme.Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
cc @bigcommerce/storefront-team