Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: STRF-11281 Narrow comma separation cases and Improve Base Rules Error #1139

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Oct 6, 2023

What?

Fixed and improved couple autofix rules:

  • Narrowed bad-comma detection mechanism (previously some cases where detected as bad-comma while they weren't)
  • fixed issues with comments in base-level rules containing parent selector &.

Tickets / Documentation

Screenshots (if appropriate)

1 case
Before:
Screenshot 2023-10-06 at 15 31 12
After:
Screenshot 2023-10-06 at 17 53 18

2 case:
Before:
Screenshot 2023-10-06 at 20 36 14
After:
Screenshot 2023-10-06 at 20 36 43

cc @bigcommerce/storefront-team

@jairo-bc jairo-bc merged commit 3879486 into master Oct 6, 2023
6 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

🎉 This PR is included in version 7.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

jairo-bc added a commit to jairo-bc/stencil-cli that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants