feat: STRF-11741 Stencil init: auto install dependencies #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvuki
approved these changes
Apr 9, 2024
bc-max
approved these changes
Apr 9, 2024
| prompts.push({ | ||
| type: 'list', | ||
| name: 'packageManager', | ||
| message: 'What is your favourite Package Manager?', |
There was a problem hiding this comment.
The question itself sounds like a matter of taste. However, if I understood correctly we want to ask What package manager do you want to use?. Sometimes answers on these 2 questions could be different. Just a thought.
There was a problem hiding this comment.
It is pretty much actually. Even if pnpm is the fastest, it's still a matter of taste. Actually, I took the question from Catalyst, so I think should be fine for now
|
This PR breaks automation because it does not allow supplying the packageManager value in the command line parameter, so it's just stuck waiting for the packageManager input. |
|
This is a breaking change which broke our automation today. What was the purpose of this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
On Stencil init we are going to ask what's your package manager of flavour and install theme dependencies to eliminate additional command running
Tickets / Documentation
Screenshots (if appropriate)
cc @bigcommerce/storefront-team