fix: strf-8574, bump version of "github" package to fix security issues + refactor the related JS file #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, the module '/lib/release.js' is pretty messy. But it can be done as the next step (to lighten this PR). |
|
@MaxGenash can you please rebase this branch. |
added 2 commits
August 3, 2020 20:36
Node-github was renamed to @octokit/rest
MaxGenash
force-pushed
the
STRF-8574_Update-packages-on-Stencil-CLI-to-address-severity-issues--pr3
branch
from
2feb3dd to
720fbb1
Compare
junedkazi
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Bumped version of the outdated npm module "github" (which was renamed to "@octokit/rest") to fix security vulnerabilities.
The newer version of the npm module had a lot of braking changes, so I had to update our core as well (the first commit).
Also refactored the related JS file to use async/await instead of callbacks (the second commit).
Tickets / Documentation
This PR is a part of STRF-8574 (since there are going to be a lot of updates they will be split into several PRs).