-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STRF-8747: split .stencil file into 2 separate config files #662
STRF-8747: split .stencil file into 2 separate config files #662
Conversation
👏 thanks for doing this. As some existing users of CLI may be expecting the |
@MaxGenash can you also add these files to https://github.com/bigcommerce/cornerstone/blob/master/.gitignore#L2 This will help make sure theme developers do not accidentally commit them to source control. |
@bookernath I implemented smooth backward compatibility, so at the moment when users reference the |
@MaxGenash great, good thinking and thank you for clarifying! |
@MaxGenash can you make sure we are not pushing the credentials file when we do a stencil push or when we make a bundle |
@junedkazi checked, we are not pushing the credentials file when we do a stencil push or when we make a bundle |
@bookernath @junedkazi before releasing these changes, need to update the documentation on developer.bigcommerce.com to replace mentions of .stencil with the new files and update videos on YouTube where .stncil file is edited (e.g. https://youtu.be/qgaDX7bhmd8 ) |
What?
.stencil
file into a separate class..stencil
file into 2 separate config files:secrets.stencil.json
(contains "accessToken", "githubToken") andconfig.stencil.json
(all other fields), so that themes developers can optionally keep general config data (config.stencil.json
) in git and addsecrets.stencil.json
to .gitignore. Also implemented migration from an old config file format on config read to avoid breaking changes.Tickets / Documentation
Ticket: STRF-8747
Issue: #523