STRF-9019: fixed wrong reading from stream in archiveManager that was breaking stencil-download command #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGenash
force-pushed
the
STRF-9019_Stencil_Push_causing_tr-300_error
branch
2 times, most recently
from
ed3f5d0 to
a3e5872
Compare
MaxGenash
force-pushed
the
STRF-9019_Stencil_Push_causing_tr-300_error
branch
from
a3e5872 to
eb9b082
Compare
jairo-bc
approved these changes
Mar 2, 2021
This was referenced Mar 11, 2021
stanosmithpt
added a commit
to Plant-Therapy/cornerstone
that referenced
this pull request
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There was a bug in archiveManager.js: data from the stream was read as a string instead of Buffer which caused breaking binary data, esp. images. The archiveManager was used by stencil-download command, so this command was spoiling images and as a side effect increasing their size x2. It resulted in a problem that the spoiled images started exceeding the size limit of 5MB which caused tr-300 errors when calling stencil-push.
Tickets / Documentation
#670 = STRF-8865
#632 = STRF-8851,
#682 = STRF-9019.